fix: error when current context is undefined, CLI symbol is undefined#386
Merged
fix: error when current context is undefined, CLI symbol is undefined#386
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 67 67
Lines 1792 1793 +1
Branches 379 379
=========================================
+ Hits 1792 1793 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arjuncooliitr
approved these changes
May 29, 2025
dthampy
approved these changes
May 29, 2025
MichaelGoberling
approved these changes
May 29, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that when no IMS context is set, the CLI context is used by default to retrieve an access token, preventing the undefined-context error.
- Added a truthy check around
currentContextto preserve the default CLI context when it’s undefined. - Updated the test to mock
currentContextasundefinedand validate the fallback. - Adjusted import of
CLIfrom the IMS library.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/DeployServiceCommand.test.js | Updated test to simulate currentContext being undefined and renamed test case. |
| src/DeployServiceCommand.js | Added currentContext truthy check; changed CLI import to a deep path. |
Comments suppressed due to low confidence (1)
test/DeployServiceCommand.test.js:65
- [nitpick] Consider adding an assertion to verify that
context.setCliis invoked whencurrentContextisundefinedto fully cover the fallback logic.
test('should use CLI context (default) if current context undefined', async () => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an AB project:
Description
When the current ims context is not set, you can't get an access token. A truthy check was missing.
How Has This Been Tested?
aio plugins link .to this PR branchaio config del imsaio rt trigger create trigger123Types of changes
Checklist: